Hundreads of possible broken SVG files #1255
Comments
|
ABCD_297.svg: so we are one step (from hundreds) closer to the perfect lib :D |
|
New list with svg files that are not square and without any text - NotText.zip |
|
New pack of 84 svg files in which differences are clearly visible - BrokenSVG.zip (master branch with applied patch from #1375)
In this list are only files without:
|
|
why without |
In a case where both the clipper and the clippee are transformed, the final clipper transformation matrix should be calculated as the multiplication of both matrices. @issue: thorvg#1255
|
In most of the time I use compiled version of thorvg without images support(without any reason), later I may enable it to find more differences KOSZ_8786 example is strange, because I used automatic generation for this image with command Looks that this files only draws partially due #1370 (In 1000 tested same files I got 3 AddressSanitizer crashes and also 3 same broken files were produced) |
In a case where both the clipper and the clippee are transformed, the final clipper transformation matrix should be calculated as the multiplication of both matrices. @issue: thorvg#1255
|
Broken files(png files which looks different than with rsvg) and problematic files(files which cause crashes or cannot be parsed by this tool) will now be automatically found by CI once per week - https://github.com/qarmin/SVG-regression-finder/actions List of broken files should be available as artifacts of CI job like in - https://github.com/qarmin/SVG-regression-finder/actions/runs/4766345140 Currently due #1370 sometimes thorvg freeze, so until this issue is fixed, CI will likely fail most of the time. |
|
Is it possible to separate into two ci actions that pass tests and pass failing tests |
|
Probably this should be quite easy to do, but I don't see too but I don't see good reason to do it. Such a list would have to be reviewed and corrected from time to time (when, for example, something broke, or something was fixed) and bugs in subsequent versions should be reported for repair. I don't think I or anyone else would want to look in a separate repo to see if anything has gone wrong with this repo in the meantime. In my opinion, this repo(thorvg) should have a method in the CI to check for regression e.g. via comparing output of MR and develop(using my app or a simplified version). Rsvg already uses a CI that compares the versions of the app by how many pixels they differ in examples svg files. |
The directive is used to give a specific style property higher priority, ensuring that it overrides other style declarations for the same property. @issue: thorvg#1255
|
KOSZ_998 KOSZ_31974 - deprecated 'flowRoot' - this was a feature described in one of the svg tiny versions pkt 4, but was removed from the latter versions. KOSZ_6250 - nested svgs - not supported for now (and no plans?) KOSZ_23134 - !important directive - #1426 KOSZ_5527 - TODO/check @qarmin could you please confirm that for now only the two files (KOSZ_5527 and KOSZ_7171) are problematic (I mean and all the other I listed above :) but I don;t think that we want to fix the other ones )? I could miss something |
|
With disabled entity, flowroot, nested svg and important directive I see different results in 7 files I prepared new pack of 62 files with disabled items with specific features - BrokenSVG2.zip
|
|
it's like never ending story :D |
The directive is used to give a specific style property higher priority, ensuring that it overrides other style declarations for the same property. @issue: thorvg#1255
The directive is used to give a specific style property higher priority, ensuring that it overrides other style declarations for the same property. @issue: thorvg#1255
The directive is used to give a specific style property higher priority, ensuring that it overrides other style declarations for the same property. @issue: thorvg#1255
The directive is used to give a specific style property higher priority, ensuring that it overrides other style declarations for the same property. Custom _strndup function introduced. @issue: thorvg#1255
The if-check to skip-rule when drawing an arc path is already checked in line 476. In addition, since the float type equal check is performed in the range of 1/256, unintentional skiped may occur. Therefore, remove duplicate code. https://www.w3.org/TR/SVG2/paths.html#ArcOutOfRangeParameters test file: SVG_FILE_147893.svg related issue: #1255
The if-check to skip-rule when drawing an arc path is already checked in line 476. In addition, since the float type equal check is performed in the range of 1/256, unintentional skiped may occur. Therefore, remove duplicate code. https://www.w3.org/TR/SVG2/paths.html#ArcOutOfRangeParameters test file: SVG_FILE_147893.svg related issue: #1255
And unsupported features SVG_FILE_157828.svg - mix-blend-mode:multiply SVG_FILE_158921.svg - x:href SVG_FILE_153630.svg - switch / foreignObject SVG_FILE_153521.svg - switch SVG_FILE_153433.svg - mix-blend-mode:multiply SVG_FILE_152977.svg - pattern |
|
New pack of broken files - broken-images.7z.zip Disabled elements |
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: thorvg#1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
The if-check to skip-rule when drawing an arc path is already checked in line 476. In addition, since the float type equal check is performed in the range of 1/256, unintentional skiped may occur. Therefore, remove duplicate code. https://www.w3.org/TR/SVG2/paths.html#ArcOutOfRangeParameters test file: SVG_FILE_147893.svg related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
The if-check to skip-rule when drawing an arc path is already checked in line 476. In addition, since the float type equal check is performed in the range of 1/256, unintentional skiped may occur. Therefore, remove duplicate code. https://www.w3.org/TR/SVG2/paths.html#ArcOutOfRangeParameters test file: SVG_FILE_147893.svg related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
Checks whether the string that can be specified in Color is valid.
example)
```
style="stroke:asdasd"
```
related issue: #1255
|
New pack - broken-images.zip |
This files were found programmatically, so not all this images are invalid.
To check if png created from svg is valid I:
inkscape --export-type=png -h 500)svg2png -r 500x500)This is not ideal comparison, because for some files inkscape generate invalid png files.
Even if files looks in file browser preview similar, then I suggest to look at them closer, because probably they differ in shadows or other less visible things.
SVG.zip
The text was updated successfully, but these errors were encountered: