Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stroke regression bug #1670

Closed
hermet opened this issue Sep 25, 2023 · 1 comment
Closed

Stroke regression bug #1670

hermet opened this issue Sep 25, 2023 · 1 comment
Assignees
@hermet
Labels
bug Something isn't working image Bitmap image features (jpg/png/webp/gif)
Milestone
0.11

Comments

@hermet
Copy link
Member

hermet commented Sep 25, 2023

image

<svg viewBox="0 0 2 2">
<path d="M.604.605L.75.922C.754.896.77.877.783.855l.356.354a.9.9 0 00-.239.535H.7c-.081-.006-.081.118 0 .111h1.1c.03 0 .055-.024.055-.054V.699A.056.056 0 001.8.643a.056.056 0 00-.055.056V.9a.9.9 0 00-.535.239L.857.785C.88.773.897.755.922.752L.604.605zM1.744 1v.674l-.463-.465A.832.832 0 011.744 1zm-.537.28l.467.464H1a.778.778 0 01.207-.465z" stroke="#F00" stroke-width="0.05" fill="blue"/>
</svg>
@hermet hermet added the bug Something isn't working label Sep 25, 2023
@hermet hermet added this to the 0.11 milestone Sep 25, 2023
@hermet hermet mentioned this issue Sep 25, 2023
Closed
21 tasks
@hermet hermet self-assigned this Sep 25, 2023
@hermet hermet added the image Bitmap image features (jpg/png/webp/gif) label Sep 25, 2023
@hermet
Copy link
Member Author

hermet commented Sep 26, 2023

Issue Patch:

commit d683d2e
Author: Hermet Park hermet@lottiefiles.com
Date: Thu Sep 14 15:44:24 2023 +0900

sw_engine: Do not handle exceptions for zero line length.

While it may represent a dot with a stroke width,
ignoring its length is not a good idea.

this also eliminates 0 size dash dots caused by unexpected empty lengths.

hermet added a commit that referenced this issue Sep 26, 2023
@hermet
sw_engine: fix a regression stroke bug
7fd795f 
reverted changes that occurred this issue from d683d2e

Issue: #1670
@hermet hermet mentioned this issue Sep 26, 2023
Merged
@hermet hermet closed this as completed Sep 26, 2023
hermet added a commit that referenced this issue Sep 26, 2023
@hermet
sw_engine: fix a regression stroke bug
e4ade98 
reverted changes that occurred this issue from d683d2e

Issue: #1670
capnm added a commit to capnm/godot4 that referenced this issue Sep 29, 2023
@capnm
ThorVG: update to v0.11.0 release.
6aac632 
See https://github.com/thorvg/thorvg/releases/tag/v0.11.0

+ Infrastructure
    Repository folder structure was make it more intuitive and coherent.
        "thorvg/src/lib" -> "thorvg/src/common"
            (providing essential common functionalities
                used internally among the renderer and sub-modules)
        "thorvg/src/lib" -> "thorvg/src/renderer"
            (for vector drawing features)

+ SVG related
    Fix stroke regression thorvg/thorvg#1670
    Support stroke dash offset function thorvg/thorvg#1591 (comment)
    Support Focal property in Radial Gradient thorvg/thorvg#1558
capnm added a commit to capnm/godot4 that referenced this issue Sep 29, 2023
@capnm
ThorVG: update to v0.11.0 release.
794d02c 
See https://github.com/thorvg/thorvg/releases/tag/v0.11.0

+ Infrastructure
    Repository folder structure was make it more intuitive and coherent.
        "thorvg/src/lib" -> "thorvg/src/common"
            (providing essential common functionalities
                used internally among the renderer and sub-modules)
        "thorvg/src/lib" -> "thorvg/src/renderer"
            (for vector drawing features)

+ SVG related
    Fix stroke regression thorvg/thorvg#1670
    Support stroke dash offset function thorvg/thorvg#1591 (comment)
    Support Focal property in Radial Gradient thorvg/thorvg#1558
capnm added a commit to capnm/godot4 that referenced this issue Sep 29, 2023
@capnm
ThorVG: update to v0.11.0 release.
aab650f 
See https://github.com/thorvg/thorvg/releases/tag/v0.11.0

+ Infrastructure
    Repository folder structure was make it more intuitive and coherent.
        "thorvg/src/lib" -> "thorvg/src/common"
            (providing essential common functionalities
                used internally among the renderer and sub-modules)
        "thorvg/src/lib" -> "thorvg/src/renderer"
            (for vector drawing features)

+ SVG related
    Fix stroke regression thorvg/thorvg#1670
    Support stroke dash offset function thorvg/thorvg#1591 (comment)
    Support Focal property in Radial Gradient thorvg/thorvg#1558
@capnm capnm mentioned this issue Sep 29, 2023
Merged
mandryskowski pushed a commit to mandryskowski/godot that referenced this issue Oct 11, 2023
@capnm @mandryskowski
ThorVG: update to v0.11.0 release.
a437d30 
See https://github.com/thorvg/thorvg/releases/tag/v0.11.0

+ Infrastructure
    Repository folder structure was make it more intuitive and coherent.
        "thorvg/src/lib" -> "thorvg/src/common"
            (providing essential common functionalities
                used internally among the renderer and sub-modules)
        "thorvg/src/lib" -> "thorvg/src/renderer"
            (for vector drawing features)

+ SVG related
    Fix stroke regression thorvg/thorvg#1670
    Support stroke dash offset function thorvg/thorvg#1591 (comment)
    Support Focal property in Radial Gradient thorvg/thorvg#1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermet hermet

Labels
bug Something isn't working image Bitmap image features (jpg/png/webp/gif)
Projects
ThorVG
Status: Done 0.11
Milestone
0.11
Development

No branches or pull requests
1 participant
@hermet