Support pure sync mode without mutexes and tasks #1900
Assignees
Labels
Milestone
Comments
|
@kisvegabor Hello, I agree with your opinion. We can remove the threading feature from the compilation on the end side. Please let me consider making it compilable for both scenarios. I will come up with the solution. |
|
Thank you! 😊 We copy pasted the source code ThorVG into LVGL and modified it a little bit. Therefore for us the best would be to have a define in a config file we can alter this behavior. |
hermet
added a commit
that referenced
this issue
Jan 15, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... The thread feature is enabled in default. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 15, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... The thread feature is enabled in default. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 15, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... The thread feature is enabled in default. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 15, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 15, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 16, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 17, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 17, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 18, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Jan 18, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
hermet
added a commit
that referenced
this issue
Apr 5, 2024
Some systems such as micro-processor might not support the thread feature on the system. Enhance the portability by compiling the thorvg with toggling the threading depepdency through the build option. For this, thorvg newly introduced the internal Key/ScopedLock abstraction for transparent thread-locking dependnecy. To turn off the thread feature, please use the next build option: $meson setup build -Dthreads=false ... Note that, the thread feature is enabled in default. Turning off the thread feature could reduce the binary size by 7kb. issue: #1900
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I built ThorVG on STM32 it turned out the
mutexand some other task related C++ modules are not implemented there. I haven't tried, but I suspect that it's true for other vendors/platforms too.As we are using ThorVG only in sync mode I removed all the mutex and task related parts from
tvgTaskScheduler.cppandtvgTaskScheduler.h. See the changes here lvgl/lvgl#5249Now it works, but I wonder if it would make sense to allow enabling a simple "sync only" mode with a define.
What do you think?
The text was updated successfully, but these errors were encountered: