Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lottie regression bug #2021

Closed
hermet opened this issue Mar 3, 2024 · 1 comment
Closed

Lottie regression bug #2021

hermet opened this issue Mar 3, 2024 · 1 comment
Assignees
@mgrudzinska
Labels
bug Something isn't working showstopper Regression bugs / Critical errors

Comments

@hermet
Copy link
Member

hermet commented Mar 3, 2024 •
edited

This patch broke the lottie trimpath animations:
#1985

threads.json
sample2.json
@hermet hermet added bug Something isn't working showstopper Regression bugs / Critical errors labels Mar 3, 2024
@hermet
Copy link
Member Author

hermet commented Mar 3, 2024

@mgrudzinska

@mgrudzinska mgrudzinska self-assigned this Mar 3, 2024
mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue Mar 3, 2024
@mgrudzinska
sw_engine: fix a regression bug
fe09314 
After introducing the length measurement
of approximate and exact Bezier curves in
a8c0030
the calculation of the outline length still
used the approximate functions, while further
calculations took the exact value into account.
This discrepancy led to the creation of artifacts.

@issue: thorvg#2021
@mgrudzinska mgrudzinska mentioned this issue Mar 3, 2024
Merged
hermet pushed a commit that referenced this issue Mar 4, 2024
@mgrudzinska @hermet
sw_engine: fix a regression bug
f535a6e 
After introducing the length measurement
of approximate and exact Bezier curves in
a8c0030
the calculation of the outline length still
used the approximate functions, while further
calculations took the exact value into account.
This discrepancy led to the creation of artifacts.

@issue: #2021
@hermet hermet closed this as completed Mar 4, 2024
hermet pushed a commit that referenced this issue Mar 8, 2024
@mgrudzinska @hermet
sw_engine: fix a regression bug
4c8ceb3 
After introducing the length measurement
of approximate and exact Bezier curves in
a8c0030
the calculation of the outline length still
used the approximate functions, while further
calculations took the exact value into account.
This discrepancy led to the creation of artifacts.

@issue: #2021
hermet pushed a commit that referenced this issue Apr 5, 2024
@mgrudzinska @hermet
sw_engine: fix a regression bug
5392c27 
After introducing the length measurement
of approximate and exact Bezier curves in
a8c0030
the calculation of the outline length still
used the approximate functions, while further
calculations took the exact value into account.
This discrepancy led to the creation of artifacts.

@issue: #2021
hermet pushed a commit that referenced this issue Apr 6, 2024
@mgrudzinska @hermet
sw_engine: fix a regression bug
203d892 
After introducing the length measurement
of approximate and exact Bezier curves in
a8c0030
the calculation of the outline length still
used the approximate functions, while further
calculations took the exact value into account.
This discrepancy led to the creation of artifacts.

@issue: #2021
@mgrudzinska mgrudzinska mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrudzinska mgrudzinska

Labels
bug Something isn't working showstopper Regression bugs / Critical errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hermet @mgrudzinska