Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storing the address of local variable #2051

Closed
kisvegabor opened this issue Mar 13, 2024 · 2 comments
Closed

Storing the address of local variable #2051

kisvegabor opened this issue Mar 13, 2024 · 2 comments
Assignees
@hermet
Labels
lottie Lottie animation portability Portability Issues among the machines
Milestone
0.13

Comments

@kisvegabor
Copy link
Member

Hi,

While compiling ThorVG for ESP32 I get this warning (converted to error):

error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;
@hermet hermet added portability Portability Issues among the machines lottie Lottie animation labels Mar 14, 2024
@hermet hermet added this to the 0.13 milestone Mar 14, 2024
@hermet hermet self-assigned this Mar 14, 2024
hermet added a commit that referenced this issue Mar 14, 2024
@hermet
lottie: fixed a compiler warning:
2dd8118 
error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;

issue: #2051
@hermet hermet mentioned this issue Mar 14, 2024
Merged
@hermet
Copy link
Member

hermet commented Mar 14, 2024

@kisvegabor hello, you might wanna confirm fix by this #2052

hermet added a commit that referenced this issue Mar 14, 2024
@hermet
lottie: fixed a compiler warning:
211f0dc 
error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;

issue: #2051
@hermet
Copy link
Member

hermet commented Mar 14, 2024

@kisvegabor the fix will be in 0.12.8 thanks.

@hermet hermet closed this as completed Mar 14, 2024
hermet added a commit that referenced this issue Mar 15, 2024
@hermet
lottie: fixed a compiler warning:
37fbe9d 
error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;

issue: #2051
hermet added a commit that referenced this issue Apr 5, 2024
@hermet
lottie: fixed a compiler warning:
a7fbdad 
error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;

issue: #2051
hermet added a commit that referenced this issue Apr 6, 2024
@hermet
lottie: fixed a compiler warning:
b1ab52f 
error: storing the address of local variable 'context' in '*this.LottieParser::context' [-Werror=dangling-pointer=]
 1255 |     this->context = &context;

issue: #2051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hermet hermet

Labels
lottie Lottie animation portability Portability Issues among the machines
Projects
ThorVG
Status: Done 0.13
Milestone
0.13
Development

No branches or pull requests
2 participants
@hermet @kisvegabor