Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded compilers doesn't like _A, _B, and _C function names. #2062

Closed
kisvegabor opened this issue Mar 16, 2024 · 0 comments
Closed

Embedded compilers doesn't like _A, _B, and _C function names. #2062

kisvegabor opened this issue Mar 16, 2024 · 0 comments
Assignees
Labels
lottie Lottie animation portability Portability Issues among the machines showstopper Regression bugs / Critical errors
Milestone

Comments

@kisvegabor
Copy link
Member

Hi,

I'm not sure why, but I get an error for these 3 function names. Maybe these are reserved or used internally somewhere. I got this with error with multiple compilers.

/home/kisvegabor/projects/lvgl/esp-workspace/esp-bsp/examples/display_lvgl_demos/components/lvgl/src/libs/thorvg/tvgLottieInterpolator.cpp:44:21: error: expected unqualified-id before numeric constant
   44 | static inline float _B(float aA1, float aA2) { return 3.0f * aA2 - 6.0f * aA1; }
      |                     ^~

Renaming the function to tvg_A, tvg_B, and tvg_C solves the issue. Basically adding any letter before the _ is fine.

@hermet hermet added portability Portability Issues among the machines lottie Lottie animation labels Mar 16, 2024
@hermet hermet added the showstopper Regression bugs / Critical errors label Mar 16, 2024
@hermet hermet added this to the 0.13 milestone Mar 17, 2024
tinyjin added a commit to tinyjin/thorvg that referenced this issue Mar 17, 2024
Fixed naming conflict in short names.

issue: thorvg#2062
tinyjin added a commit to tinyjin/thorvg that referenced this issue Mar 17, 2024
Fixed naming conflict in short names.

issue: thorvg#2062
hermet pushed a commit that referenced this issue Mar 18, 2024
Fixed naming conflict in short names.

issue: #2062
@hermet hermet closed this as completed Mar 18, 2024
hermet pushed a commit that referenced this issue Mar 21, 2024
Fixed naming conflict in short names.

issue: #2062
hermet pushed a commit that referenced this issue Apr 5, 2024
Fixed naming conflict in short names.

issue: #2062
hermet pushed a commit that referenced this issue Apr 6, 2024
Fixed naming conflict in short names.

issue: #2062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lottie Lottie animation portability Portability Issues among the machines showstopper Regression bugs / Critical errors
Projects
Status: Done 0.13
Development

No branches or pull requests

3 participants