Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim paths speed do not match original clip #2173

Closed
hermet opened this issue Apr 13, 2024 · 0 comments
Closed

Trim paths speed do not match original clip #2173

hermet opened this issue Apr 13, 2024 · 0 comments
Assignees
@mgrudzinska
Labels
bug Something isn't working lottie Lottie animation
Milestone
0.14

Comments

@hermet
Copy link
Member

hermet commented Apr 13, 2024 •
edited
Loading

It seems to be an thorvg issue with the implementation differences of trimpath.
see: LottieFiles/dotlottie-web#178 (comment)
@hermet hermet added lottie Lottie animation bug Something isn't working labels Apr 13, 2024
mgrudzinska added a commit to mgrudzinska/thorvg that referenced this issue Apr 15, 2024
@mgrudzinska
sw_engine: fix max length of trimmed strokes
6ac453a 
The error was visible when multiple shapes were
simultaneously trimmed. The length of a single
shape was zeroed out only in selected cases,
which caused accumulation that could lead to
incorrect extension of the variable determining
the maximum length.

@issue: thorvg#2173
@mgrudzinska mgrudzinska mentioned this issue Apr 15, 2024
Merged
@mgrudzinska mgrudzinska self-assigned this Apr 15, 2024
@hermet hermet added this to the 0.14 milestone Apr 16, 2024
hermet pushed a commit that referenced this issue Apr 17, 2024
@mgrudzinska
sw_engine: fix max length of trimmed strokes
3a03fd7 
The error was visible when multiple shapes were
simultaneously trimmed. The length of a single
shape was zeroed out only in selected cases,
which caused accumulation that could lead to
incorrect extension of the variable determining
the maximum length.

@issue: #2173
@hermet hermet closed this as completed Apr 17, 2024
hermet pushed a commit that referenced this issue Apr 19, 2024
@mgrudzinska @hermet
sw_engine: fix max length of trimmed strokes
b7ecc8f 
The error was visible when multiple shapes were
simultaneously trimmed. The length of a single
shape was zeroed out only in selected cases,
which caused accumulation that could lead to
incorrect extension of the variable determining
the maximum length.

@issue: #2173
hermet pushed a commit that referenced this issue Apr 19, 2024
@mgrudzinska @hermet
sw_engine: fix max length of trimmed strokes
f87601d 
The error was visible when multiple shapes were
simultaneously trimmed. The length of a single
shape was zeroed out only in selected cases,
which caused accumulation that could lead to
incorrect extension of the variable determining
the maximum length.

@issue: #2173
hermet pushed a commit that referenced this issue Jun 24, 2024
@mgrudzinska @hermet
sw_engine: fix max length of trimmed strokes
179e2eb 
The error was visible when multiple shapes were
simultaneously trimmed. The length of a single
shape was zeroed out only in selected cases,
which caused accumulation that could lead to
incorrect extension of the variable determining
the maximum length.

@issue: #2173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgrudzinska mgrudzinska

Labels
bug Something isn't working lottie Lottie animation
Projects
ThorVG
Status: Done 0.14
Milestone
0.14
Development

No branches or pull requests
2 participants
@hermet @mgrudzinska