sw_engine/stroke: Enhance the quality of the dash line corners. #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the engine didn't properly cover the dash line corner styles because it considered a new line to start at the corner. This update modifies the logic to recognize curved lines as a single line, including the corners. There may still be some quality issues, but it's an improvement over the previous version. @issue: #121
hermet
added
enhancement
|
I did a quick test of the PR while working on other Godot issues 👍 Details:
I have noticed that the stroke-dashoffset isn't calculated correctly. Details:Related (line example): #1591 #1607
<svg width="512" height="512" version="1.1" viewBox="0 0 512 512" xmlns="http://www.w3.org/2000/svg">
<g fill="none">
<g stroke-width="20">
<path d="m20 40h120l-20 90-80-10v-100" stroke="#f00" stroke-linecap="round" stroke-linejoin="bevel"/>
<path d="m170 40h120l-20 90-80-10v-100" stroke="#ff0" stroke-linecap="square" stroke-linejoin="bevel"/>
<path d="m320 40h120l-20 90-80-10v-100" stroke="#0f0" stroke-linecap="square" stroke-miterlimit="5"/>
</g>
<g stroke-dasharray="40, 40, 60" stroke-width="20">
<path d="m20 175.21h120l-20 90-80-10v-100" stroke="#f00" stroke-linecap="round" stroke-linejoin="round"/>
<path d="m170 175.21h120l-20 90-80-10v-100" stroke="#ff0" stroke-linecap="square" stroke-linejoin="bevel"/>
<path d="m320 175.21h120l-20 90-80-10v-100" stroke="#0f0" stroke-linecap="square" stroke-miterlimit="5"/>
</g>
<g stroke-width="15">
<path d="m137.52 295.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#f00" stroke-linecap="round" stroke-linejoin="round"/>
<path d="m287.52 295.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#ff0" stroke-linecap="square" stroke-linejoin="bevel"/>
<path d="m437.52 295.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#0f0" stroke-linecap="square" stroke-miterlimit="5"/>
</g>
<g stroke-dashoffset="10" stroke-width="10">
<path d="m137.52 405.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#f00" stroke-dasharray="30,20" stroke-linecap="round" stroke-linejoin="round"/>
<path d="m287.52 405.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#ff0" stroke-dasharray="30, 20" stroke-linecap="square" stroke-linejoin="bevel"/>
<path d="m437.52 405.83a100 100 0 0 1-58.193 77.9l-40.912-91.248z" stroke="#0f0" stroke-dasharray="30, 20" stroke-linecap="square" stroke-miterlimit="5"/>
</g>
<g stroke="#ff0" stroke-linejoin="bevel" stroke-width="10">
<ellipse cx="475" cy="245" rx="15" ry="75" stroke-dashoffset="5"/>
<ellipse cx="475" cy="410" rx="15" ry="75" stroke-dasharray="30, 10" stroke-dashoffset="20"/>
<ellipse cx="475" cy="79.999" rx="15" ry="75" stroke-dasharray="30" stroke-linecap="square"/>
</g>
</g>
</svg> |
|
Title: |
hermet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the engine didn't properly cover the dash line corner styles because it considered a new line to start at the corner.
This update modifies the logic to recognize curved lines as a single line, including the corners.
There may still be some quality issues,
but it's an improvement over the previous version.
@issue: #121