svg_loader SvgLoader: Print inefficient elements #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermet
requested changes
Dec 17, 2020
src/loaders/svg/tvgSvgLoaderCommon.h
Outdated
| @@ -347,4 +347,33 @@ struct SvgLoaderData | |||
| bool result = false; | |||
| }; | |||
|
|
|||
| #ifdef THORVG_LOG_ENABLED | |||
| inline string nodeTypeToString(SvgNodeType type) | |||
There was a problem hiding this comment.
does it necessary to use inline? leave to compiler if possible
Also, if it uses only in _inefficientNodeCheck(), you can move it in one same place.
#ifdef THORVG_LOG_ENABLED
static string _nodeTypeToString()
{
...
}
static void _inefficientNodeCheck()
{
...
}
#endif
There was a problem hiding this comment.
Removed inline
and _nodeTypeToString is also used in XmlParser.cpp. Therefore, it cannot be moved to tvgSvgLoader.
Opacity is 0 both Fill.Opacity and Stroke Opacity are 0 point is 0 in Path declared display="none" width or height of bounds becomes 0
JSUYA
force-pushed
the
devs/jsuya/inefficient
branch
from
fcf8352
to
ce1e5be
Compare
hermet
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description :
Opacity is 0
both Fill.Opacity and Stroke Opacity are 0
point is 0 in Path
declared display="none"
width or height of bounds becomes 0
Issue Tickets (if any) :
Extend ThorVG Viewer to display unnecessary or ineffcient elements. #153