test: Updated test code for the lottie slot #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinyjin
requested review from
JSUYA,
RuiwenTang,
SergeyLebedkin,
mgrudzinska and
hermet
as code owners
JSUYA
reviewed
Mar 6, 2024
tinyjin
force-pushed
the
jinny/slot-test-code
branch
from
43c3acb
to
d7ae7c3
Compare
hermet
reviewed
Mar 6, 2024
|
|
||
| auto picture = animation->picture(); | ||
| REQUIRE(picture->identifier == Picture::identifier); | ||
|
|
There was a problem hiding this comment.
Probably, you might wanna add a negative test at this point,
override() before load()
| Tvg_Identifier id = TVG_IDENTIFIER_UNDEF; | ||
| REQUIRE(tvg_paint_get_identifier(picture, &id) == TVG_RESULT_SUCCESS); | ||
| REQUIRE(id == TVG_IDENTIFIER_PICTURE); | ||
|
|
There was a problem hiding this comment.
Probably, you might wanna add a negative test at this point,
override() before load()
hermet
reviewed
Mar 6, 2024
| REQUIRE(id == TVG_IDENTIFIER_PICTURE); | ||
|
|
||
| REQUIRE(tvg_picture_load(picture, TEST_DIR"/lottieslot.json") == TVG_RESULT_SUCCESS); | ||
|
|
There was a problem hiding this comment.
also, maybe a call override() here with an invalid slot data.
tinyjin
force-pushed
the
jinny/slot-test-code
branch
2 times, most recently
from
c33e9ab
to
49cd9af
Compare
hermet
force-pushed
the
jinny/slot-test-code
branch
from
49cd9af
to
1db241c
Compare
hermet
reviewed
Mar 6, 2024
test/testLottie.cpp
Outdated
| REQUIRE(animation->override(slotJson) == Result::Success); | ||
|
|
||
| //Slot override with invalid JSON | ||
| REQUIRE(animation->override("") == Result::InsufficientCondition); |
There was a problem hiding this comment.
For now, returns InsufficientCondition in invalid JSON, should we change the result?
There was a problem hiding this comment.
Yes, we can change it if you think it makes sense.
This patch adds the test case for the recently introduced lottie slot API. @Issues: thorvg#2029
tinyjin
force-pushed
the
jinny/slot-test-code
branch
from
1db241c
to
4608af8
Compare
hermet
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the test case for the recently introduced lottie slot API
Issue: #2029