lottie: support shape modifiers - rounded corner #2267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrudzinska
force-pushed
the
mira/rounded_star
branch
from
858cbd5
to
4096bcb
Compare
hermet
reviewed
May 13, 2024
mgrudzinska
force-pushed
the
mira/rounded_star
branch
from
4096bcb
to
d918e70
Compare
mgrudzinska
force-pushed
the
mira/rounded_star
branch
from
d918e70
to
f079ec7
Compare
hermet
reviewed
May 14, 2024
hermet
changed the title
Implementation of the roundness property for a polystar. Only the corners that were not subject to rounding by the inner or outer roundness parameters are affected. @issue: thorvg#2230
Implemented rounding of corners between bezier curves that are straight lines. @issue: thorvg#2230
Avoiding the sqrt call when calculating distance by tracking the continuity of point sequences and utilizing the previously calculated value.
mgrudzinska
force-pushed
the
mira/rounded_star
branch
from
81675ff
to
69a515d
Compare
|
abandoned the lottie: optimize roundCorner() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the roundness property
for a polystar. Only the corners that were
not subject to rounding by the inner or
outer roundness parameters are affected.
Implemented rounding of corners between
bezier curves that are straight lines.
@issue: #2230
before:
after (as in AE):
before:
after:
