lottie: implement skew transformation #2281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermet
reviewed
May 15, 2024
hermet
reviewed
May 15, 2024
Added support for skew transformation by a specified angle around a specified axis. Applied to layers and shapes, not to repeaters. @issue: thorvg#2262
hermet
reviewed
May 16, 2024
| @@ -154,6 +190,16 @@ static bool _updateTransform(LottieTransform* transform, float frameNo, bool aut | |||
| _rotateX(&matrix, transform->rotationEx->x(frameNo, exps)); | |||
| } | |||
|
|
|||
| auto skewAngle = transform->skewAngle(frameNo, exps); | |||
| if (fabsf(skewAngle) > 0.01f) { | |||
There was a problem hiding this comment.
If the exceptions are handled in 198, Please consider the most general case.
if (skewAngle != 0.0f)
is better obviously.
hermet
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for skew transformation by
a specified angle around a specified axis.
after:
expected:
skewed_stars.json