Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum update value to 0.02 #20

Open
thorwe opened this issue Mar 30, 2015 · 2 comments
Open

Change minimum update value to 0.02 #20

thorwe opened this issue Mar 30, 2015 · 2 comments
Assignees

Comments

@thorwe
Copy link
Owner

thorwe commented Mar 30, 2015

allow fastest update interval mumble link itself allows.

@thorwe thorwe self-assigned this Mar 30, 2015
@zsawyer
Copy link

zsawyer commented Mar 30, 2015

I'll create one for the minimum update value, however it'll be 0.02s as the mumble link protocol is at a fixed 50 times per second rate for updates.

Though 0.02 will give a fair quality I do not really see the point of artificially limiting this number when it is actually directly dependent on the server's setting. Meaning I would like to see the ability to go lower if desired. Though I haven't found the specific section I doubt that the protocol limits it to that rate only.

@thorwe
Copy link
Owner Author

thorwe commented Apr 30, 2015

Indeed it doesn't.
While the Mumble Link Client indeed reads 50 times per sec, the recommendation for game developers is to update every frame.

Hence yes, I'll look at making the lowest possible. I might throw in an interims release with 0.02 though, since I'd like to do a code review for the whole part for those faster updates (might need to use a different timer implementation etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants