Fix bug where New Publication form for Chapter could have an ISBN pre-populated but greyed out

[rhigman]

Every time a user opens the New Publications form, it's pre-populated with the details of the last Publication that was saved. For Publications with work type Book Chapter, the ISBN field in the form is greyed out, because Book Chapter Publications can't have ISBNs. This can result in a scenario where the form is populated with a non-permitted but non-removable ISBN.

[ja573]

I'd say the bug here is not that the chapter has an ISBN prepopulated, but that there's prepopulated data to begin with. The logic to prepopulate data is just meant to be used for editting, so we should just clear self.publication on create

[rhigman]

I'd say the bug here is not that the chapter has an ISBN prepopulated, but that there's prepopulated data to begin with. The logic to prepopulate data is just meant to be used for editting, so we should just clear self.publication on create

I think we may have discussed this at the time of implementation, and decided that the prepopulated data could also be useful for users adding several similar New Publications in one go. (See 8c5027e: the original logic was to clear self.publication on create, which changed in b267a45 / cbeb04d.)

Happy to change it back now if we no longer think this is the case, though.

[ja573]

I'd say the bug here is not that the chapter has an ISBN prepopulated, but that there's prepopulated data to begin with. The logic to prepopulate data is just meant to be used for editting, so we should just clear self.publication on create

I think we may have discussed this at the time of implementation, and decided that the prepopulated data could also be useful for users adding several similar New Publications in one go. (See 8c5027e: the original logic was to clear self.publication on create, which changed in b267a45 / cbeb04d.)

Happy to change it back now if we no longer think this is the case, though.

Oh, I see. I think it's more annoying (and error prone) having to delete the ISBN each time, so let's just leave it blank