Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/564 fix bibtex #566

Merged
merged 9 commits into from
Feb 29, 2024
Merged

Feature/564 fix bibtex #566

merged 9 commits into from
Feb 29, 2024

Conversation

ja573
Copy link
Member

@ja573 ja573 commented Feb 21, 2024

No description provided.

@ja573 ja573 linked an issue Feb 21, 2024 that may be closed by this pull request
@ja573 ja573 requested a review from rhigman February 22, 2024 08:22
@@ -19,5 +19,124 @@ pub(crate) trait BibtexEntry<T: BibtexSpecification> {
fn bibtex_entry(&self, w: &mut Vec<u8>) -> ThothResult<()>;
}

/// Macro to write a non-optional field in BibTeX format to a formatter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :D

}
}

/// Returns a list of authors and a list of editors concatenated by " and "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also nice :D

thoth-export-server/src/bibtex/bibtex_thoth.rs Outdated Show resolved Hide resolved
thoth-export-server/src/bibtex/bibtex_thoth.rs Outdated Show resolved Hide resolved
@ja573 ja573 requested a review from rhigman February 28, 2024 14:08
@ja573 ja573 merged commit 83b5b6b into develop Feb 29, 2024
12 checks passed
@ja573 ja573 deleted the feature/564_fix_bibtex branch February 29, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bibtex output fails when all contributors of a textbook are editors
2 participants