Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

packaging deprecates LegacyVersion causing failure if packaging is upgraded #488

Open
Gkrumbach07 opened this issue Dec 12, 2022 · 2 comments
Open

packaging deprecates LegacyVersion causing failure if packaging is upgraded #488

Gkrumbach07 opened this issue Dec 12, 2022 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.

Comments

@Gkrumbach07
Copy link
Member

Bug description

Version 0.22 of packaging deprecates LegacyVersion and LegacySpecifier which are used in this module.

Steps to Reproduce

  1. upgrade to latest version of packaging
  2. run anything

Actual behavior

module crashes

Expected behavior

module does not crash

Additional context

usage of deprecated functions are found here: https://github.com/thoth-station/python/search?q=LegacyVersion
@Gkrumbach07 Gkrumbach07 added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Dec 12, 2022
@dejanb
Copy link

dejanb commented Dec 19, 2022

I ran into the same issue, trying to install it on the clean box

pip3 install packaging==21.3

got me going. I can help with the PR, just wondering what's the desired solution here. Remove dependency on LegacyVersion or find a way to preserve functionality with the newer versions?

@codificat
Copy link
Member

We should probably remove it eventually, but I am not sure how/if this is still used in other packages that rely on thoth-python.
/sig stack-guidance

@sesheta sesheta added the sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. label Dec 23, 2022
@codificat codificat mentioned this issue Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance.
Projects
Planning Board
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dejanb @codificat @Gkrumbach07 @sesheta