Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the Sidebar State Report #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DerDieDasDeakin
Copy link

@DerDieDasDeakin DerDieDasDeakin commented Dec 15, 2023

Description

This report details the time spent attempting this and the discovery of issues when it comes to overriding .astro components. If the override problem can be solved, then this task can be completed as the current custom Sidebar.astro file will successfully save the state of the sidebar.

Fixes #
Sidebar not saving state after refreshing or changing page. It does work but the change needs to be made permeant through overriding.

Type of change

  • Documentation (update or new)

How Has This Been Tested?

This has been tested in Chrome and has been through immense troubleshooting. Extra details are provided in the documentation. This change did not work due to issues overriding the astro component. Extra investigation needed.

Testing Checklist

  • [X ] Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my own code
  • [X ] I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

This report details the time spent attempting this and the discovery of issues when it comes to overriding .astro components. If the override problem can be solved, then this task can be completed as the current custom Sidebar.astro file will successfully save the state of the sidebar.
Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for thoth-tech ready!

Name Link
🔨 Latest commit 56848d4
🔍 Latest deploy log https://app.netlify.com/sites/thoth-tech/deploys/657bf2b0dc569800083955dd
😎 Deploy Preview https://deploy-preview-48--thoth-tech.netlify.app/products/splashkit/documentation/splashkit-starlight-wesbite-sidebar-and-component-override-spike-outcome
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for strong-fairy-c1bde1 ready!

Name Link
🔨 Latest commit 56848d4
🔍 Latest deploy log https://app.netlify.com/sites/strong-fairy-c1bde1/deploys/657bf2b005a4330009e00528
😎 Deploy Preview https://deploy-preview-48--strong-fairy-c1bde1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omckeon
Copy link
Collaborator

omckeon commented Dec 15, 2023

Copy link
Collaborator

@omckeon omckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

Thanks to the work you did looking into this and the meeting we had, I think I may have solved the issues, so thank you for putting in this time/effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants