Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Component task-ilo-alignment-modal.coffee Review Document #49

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JayaniVimukthika
Copy link

@JayaniVimukthika JayaniVimukthika commented Dec 15, 2023

Description

As the first step of Migration: Component task-ilo-alignment-modal.coffee, comepleted the component review and created the markdown document.

Fixes # (issue)
No issues

Type of change

went through the component and reviewed how function works.
created the markdown document.

The previous PR:
https://github.com/thoth-tech/documentation/pull/472

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (update or new)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for strong-fairy-c1bde1 ready!

Name Link
🔨 Latest commit 89c5b96
🔍 Latest deploy log https://app.netlify.com/sites/strong-fairy-c1bde1/deploys/657c4c52c39a330008a9c326
😎 Deploy Preview https://deploy-preview-49--strong-fairy-c1bde1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for thoth-tech ready!

Name Link
🔨 Latest commit 89c5b96
🔍 Latest deploy log https://app.netlify.com/sites/thoth-tech/deploys/657c4c524fee6d00085b81e1
😎 Deploy Preview https://deploy-preview-49--thoth-tech.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JayaniVimukthika
Copy link
Author

@williamalowe will be reviewing this.

@williamalowe
Copy link

Reviewed 14/12/2023 - COPIED FROM PREVIOUS REPO

##Purpose

  • Not used to maintain alignment, but is used to set a unit task's
    alignment rating to a given learning outcome from an admin/convenor account,
    and apply justification as to why it relates to that learning outcoming.

##Outcomes

  • Again, does not maintain alignment.
  • Acts a popup window for Admin/Convenor accounts.
  • Does not include the ability to to enter learning outcome of assignments,
    only includes the adding a rating + justification. (adding the actual learning
    outcomes occurs on a different component).
  • Consider what data points are in use and need to be maintained
    (refer to factory and controller methods).

##Proposal

  • Consider changes that can affect how the data can be input, while
    still maintaining their typing and formats, rather than purely visual changes.
  • Consider 2 other (3 Total) different implementations, each with prototype
    and/or test data.
  • Consider advantages + disadvantages for each.
  • Ensure that passed data, and output data are maintained.

##Checklist

  • Consider more functional tests, e.g: test that data can be validated/checked
    within other components where the output data is used - student task
    submission.
  • Consider a test to ensure that data is maintained in correct format and type.

##Other notes


Re-reviewed 15/12/2023

  • Please see contributing document and ensure that documentation passes all tests. Merging will not occur otherwise.

@JayaniVimukthika
Copy link
Author

Went through the contributing document, and passed all tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants