Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Below the Surface - modify lives indicators and HP bars #205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MHLoppy
Copy link
Contributor

@MHLoppy MHLoppy commented May 16, 2024

This PR was also worked on by zhusim222. (we collaborated off-git, so unfortunately he doesn't show as a contributor by default)


Description

Updates the lives indicators and HP bars for players in both 1P and 2P modes for the sake of both clarity and aesthetics:

  • Removes the face attached to each HP bar in order to improve readability
  • Adds a darkened border to HP bars (midpoint between black and that player's "HP color")
  • Makes HP bar colors consistent between full and empty
  • Discretizes HP bars (they now have markers for each of the player's 3 HP)
  • Swaps lives indicators from helmets to faces
  • Minor additional art/code changes to support the above changes
  • (now-legacy art files have been moved to a new subfolder in case they're wanted in the future)

Composite screenshot below (the "1P" and "2P" are not part of the changes)
below the surface HP bar changes

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The game was rebuilt and run in both 1P and 2P modes. Damage was taken to test the HP bars at each level of HP. Screenshots were taken and examined to verify alignment of the modified sprites.

Testing Checklist

  • Tested in 1P mode
  • Tested in 2P mode

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I will mark this work as ready for peer review

@MHLoppy MHLoppy marked this pull request as ready for review May 16, 2024 12:05
@MHLoppy MHLoppy marked this pull request as draft May 16, 2024 12:09
@MHLoppy MHLoppy marked this pull request as ready for review May 16, 2024 12:15
@github-actions github-actions bot added the compiled the source code has been successfully compiled label May 16, 2024
@MHLoppy
Copy link
Contributor Author

MHLoppy commented May 16, 2024

Just to make it as clear as possible I'll copy this into a separate comment too:

This PR was also worked on by zhusim222. (we collaborated off-git, so unfortunately he doesn't show as a contributor by default)

@MHLoppy
Copy link
Contributor Author

MHLoppy commented May 16, 2024

@zhusim222
Copy link

the final changes look amazing! definitely an upgrade from the original health bars, especially the partitions where the player can easily tell their current HP and lives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiled the source code has been successfully compiled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants