Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add spike for Splash Kit Online research #465

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

WhyPenguins
Copy link
Contributor

Description

A pull request for the spike report regarding Splash Kit Online research.
There are two reports (the plan and outcome), along with an update to the navigation bar so the documents are viewable.

Fixes #NA

Type of change

  • Documentation (update or new)

How Has This Been Tested?

npm run lint and npm run format have both been run and now pass without any changes.
The website has also been run locally and viewed to ensure the pages show up and look correct.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

@WhyPenguins
Copy link
Contributor Author

Copy link
Contributor

@omckeon omckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - nice detail. Try to use Visual Studio Code for the text editor (it is the most commonly used). Would be interesting to see if Typescript is possible (due to Javascript being possible).

@omckeon omckeon merged commit 8dfa3c4 into thoth-tech:main Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants