Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Jaron Chen ID:220296732) Arcade Games Bug Testing #469

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

AnotherNewName
Copy link
Contributor

Description

Fixes # (issue)
Created/uploaded spike plan for bug testing the arcade games in the splashkit arcade games repo and the resulting bug reports and improvement suggestions.

Type of change

  • Documentation (update or new)

How Has This Been Tested?

The arcade games were tested on a windows 10 laptop. These documents being uploaded are the bugs/issues identified during the testing.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from ... on the Pull Request

(Jaron Chen ID:220296732) The results of the testing of the arcade games for bugs and potential improvements.
@AnotherNewName
Copy link
Contributor Author

adding an empty line before the heading on 'Pingpong playspace collision bug' file and capping line length on 'Below the surface enemy recolor' file.
Updated the 'runner dash alternate spawns' file to add in a word I overlooked/skipped/missed, as the inclusion of this one word changes the meaning of the sentence.
When I initially tested the game, found an executable for the game and assumed the executable was for the current version of the game. Turns out, it was for a previous version of the game and this improvement suggestion is not necessary as it had already been implemented.
@NateXuan
Copy link

Copy link
Contributor

@omckeon omckeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@omckeon omckeon merged commit 87fcf7b into thoth-tech:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants