Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subrepos trying to register twice? #399

Closed
ghost opened this issue Aug 30, 2018 · 4 comments
Closed

Subrepos trying to register twice? #399

ghost opened this issue Aug 30, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 30, 2018

I'm trying to use subrepos as documented here, but every time I try to build something using a subrepo, it tries to register the subrepo twice and dies with

CRITICAL: Subrepo [name] is already registered

The easiest way to reproduce this is using the pleasings repo (master at 9adc8f5b340ff517dd79048e724c40a0ed33bcae at time of writing):

git clone https://github.com/thought-machine/pleasings.git
cd pleasings
plz build @unittest_cpp//:unittest_cpp

This results in:

CRITICAL: Subrepo unittest_cpp is already registered

I get a similar effect with simple examples I write myself.

Version:

$ plz --version
Please version 13.1.1

(which is weird in and of itself, considering the latest version according to git is 13.1.0)

@ghost
Copy link
Author

ghost commented Sep 3, 2018

Could somebody please confirm if this is a bug or if I am misunderstanding how to use subrepos?

@peterebden
Copy link
Member

It is a bug - subrepos are still pretty experimental. Various of the changes in #382 will help I think, but that has fallen afoul of another issue (and I haven't had time to come back to it yet).

@peterebden
Copy link
Member

I've broken those changes out separately in #403 ; will do another release for that shortly.

@peterebden
Copy link
Member

Whoops, not come back to this one for a while - but should all be more working now. Have tested the original example and it looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant