Manually set bitcode modes #260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A framework with bitcode enabled requires the following flag to create and fill the bitcode section, `-fembed-bitcode`. However, this flag is available only in archive builds, not in normal builds where it's used the flag `-fembed-bitcode-marker` which creates a bitcode section but has a size of 1. Carthage doesn't use archive action to build frameworks which means the resulting framework will contain a bitcode section but not properly filled as expected, leading to some issues in the submission of apps to TestFlight for example.
|
Thanks @dmcrodrigues for doing this! I didn't have enough time to dig in myself. It's merged in here: bd79021 and I'll cut a new release for this and all the recent changes. |
|
Cool, I'm glad to help 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A framework with bitcode enabled requires the following flag to create and fill the bitcode section,
-fembed-bitcode. However, this flag is available only in archive builds, not in normal builds where it's used the flag-fembed-bitcode-markerwhich creates a bitcode section but has a size of 1.Carthage doesn't use archive action to build frameworks which means the resulting framework will contain a bitcode section but not properly filled as expected, leading to some issues in the submission of apps to TestFlight for example.
This PR fixes #249. There's also more information in this issue: Carthage/Carthage#535.