Adding @noescape to map operator for Array
#58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,7 +8,7 @@ | |||
|
|
|||
| - returns: A value of type `[U]` | |||
| */ | |||
| public func <^> <T, U>(f: T -> U, a: [T]) -> [U] { | |||
| public func <^> <T, U>(@noescape f: T -> U, a: [T]) -> [U] { | |||
There was a problem hiding this comment.
Variable Name Min Length Rule Violation: Variable name should be 2 characters or more: currently 1 characters (variable_name_min_length)
|
I'm a fan of this 👍, I also don't suspect we'll change this implementation to do something that wouldn't make use of @NoEscape. |
Pearapps
changed the title
map operator on Arraymap operator for Array
|
This is dope. We should do an audit of the rest of the framework to make sure there's nowhere else that we can add annotations ( Rebased and merged as 1bc4a29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
CollectionType,map's transform function is @NoEscape, this function can be too.