Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix i18n inconsistencies in forms for associations #1192
The behavior of the
The behavior of
Yes, it was necessary for me, but this is because of my computer config. I meant to remove it before opening the PR, but forgot. Thanks for catching, I’ve removed it in bc37606.…
--- Chad Pytel, Developer and CEO 617-482-1300 x113 https://thoughtbot.com https://twitter.com/thoughtbot
On Jul 20, 2018, at 3:43 PM, Nick Charlton ***@***.***> wrote: @nickcharlton commented on this pull request. Looks good! One minor comment. I'm willing to ignore CI failures as they're dependency warnings that'll get fixed elsewhere. In spec/example_app/config/database.yml <#1192 (comment)>: > @@ -1,4 +1,5 @@ development: &default + host: localhost Was this necessary to get up and running? Should we include this in this PR, or elsewhere? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1192 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAATlwytvxJZcd67FCL5PmnqTXibff3Xks5uIeyQgaJpZM4VYHIJ>.
Fixes #1105. As described in #1105, there are some inconsistencies in the way Administrate handles labels for `HasMany`/`BelongsTo`/`HasOne` associations. * `HasMany` (eg: `Order#line_items`) - Gives "line_items" as the label - No i18n. * `BelongsTo` (eg: `Customer#country`) - Defaults to "Country code" (similar to "Country id" in this case). - Allows i18n as `helpers.label.customer.country_code`. * `HasOne` (eg: `Product#product_meta_tag`) - Gives "Product Meta Tag". - No i18n. The behavior of the `BelongsTo` field is most correct, and is preserved in this commit. The behavior of `HasMany` and `HasOne` has been improved as follows: * `HasMany` (eg: `Order#line_items`) now no longer overrides the text given to the `label` helper, and passes the attribute name. This results in a default label of "Line items" and one that can be overridden with i18n with a key at the standard location (`helpers.label.order.line_items`) * `HasOne` (eg: `Product#product_meta_tag`) now can be overriden with the key `helpers.label.order.line_items`. The `HasOne` is rendered into a nested form, inside of a fieldset and with a legend. The text of the "label" in this nested form is actually in a legend tag. I considered the fact that this was not using the `label` helper, whether it should be switch to a label from a legend, or whether we should have a non-standard i18n key. In the end, I decided that the least surprising behavior would be to customize the "label" for that attribute at the expected label's i18n key.