Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word-break to attribute-data #1357

Merged
merged 1 commit into from Oct 5, 2020
Merged

Add word-break to attribute-data #1357

merged 1 commit into from Oct 5, 2020

Conversation

mikegabriel
Copy link
Contributor

Similar to #306 - but improves functionality.

Long values such as MD5 hashes are currently being outputted on a single line that expands the page for either Field::String or Field::Text. This commit adds a word-break to .attribute-data which allows word-wrapping to occur while maintaining copy and paste-ability.

Before (page scrolls a lot and has 'h-align' padding to centre it:
Screen Shot 2019-06-09 at 10 52 40 AM

After:
Screen Shot 2019-06-09 at 10 52 54 AM

@nickcharlton nickcharlton added feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with labels Jan 2, 2020
Long values such as MD5 hashes are currently being outputted on a single line
for either `Field::String` or `Field::Text`.  This commit adds a `word-break`
to `.attribute-data` which allows word-wrapping to occur while maintaining copy
and paste-ability.
@nickcharlton nickcharlton merged commit b9956ac into thoughtbot:master Oct 5, 2020
@nickcharlton
Copy link
Member

Thanks! This one must've slipped through, so I rebased and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants