Use System Fonts #409
Merged
Use System Fonts #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysongach
force-pushed
the
tg-system-fonts
branch
from
2d1149f
to
2b196f9
Compare
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| .cell-label--asc, | |||
| .cell-label--desc { | |||
| font-weight: bold; | |||
| font-weight: 600; | |||
There was a problem hiding this comment.
Fancy creating a $bold-font-weight variable for clarity?
There was a problem hiding this comment.
Yeah, probably a good idea. Updated.
tysongach
force-pushed
the
tg-system-fonts
branch
from
1f81938
to
03efe1d
Compare
|
Looks good. Much more appropriate. |
|
Lato's one of those fonts that looks great until you actually get it into a project. System fonts don't get enough respect. I like it 👍 |
tysongach
force-pushed
the
tg-system-fonts
branch
from
03efe1d
to
1871dd8
Compare
|
I'm good with it! You had me at "one fewer dependency" |
|
😆 |
added 2 commits
January 20, 2016 16:49
Lato isn't particularly made for UI uses and I felt it was a little rough around the edges; almost too friendly and unstructured for Administrate. Instead, we can just use system fonts, especially now that Apple and Google have both creating their own typefaces for UI use and are really strong typefaces. Plus we get the benefit of not having to load web fonts! Reference: https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/ It also means we have one less thing to rely on (Google Fonts)
tysongach
force-pushed
the
tg-system-fonts
branch
from
1871dd8
to
28e084f
Compare
c-lliope
added a commit
that referenced
this pull request
Jan 22, 2016
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
Merged
c-lliope
added a commit
that referenced
this pull request
Jan 22, 2016
Changes: ``` * [#269] [FEATURE] Add a generator for copying default layout files * [#328] [FEATURE] Add a generator for copying default sidebar partial * [#362] [FEATURE] Add a generator for only the dashboard manifest. Customizing this manifest before running the `administrate:install` generator will change which dashboards get generated. * [#295] [FEATURE] Add dashboard detection for ActiveRecord::Enum fields. * [#364] [FEATURE] Improve dashboard generator by explicitly listing out the generated `SHOW_PAGE_ATTRIBUTES` array elements. * [#416] [UI] Add an accessibility label to the search input * [#411] [UI] Use tabular figures in table cells * [#409] [UI] Use default system fonts * [#424] [BUGFIX] Fix a bug where running `rails destroy GENERATOR_NAME` would not work for several of the generators * [#390] [BUGFIX] Fix timestamp deprecation warnings * [#365] [COMPAT] Remove dependency on `inline_svg` * [#396] [I18n] Ukrainian * [#297] [I18n] Italian * [#307] [I18n] Fix German grammatical errors * [#363] [DOC] Move documentation into main repository, at the root URL * [#395] [DOC] Update inline documentation for collection partial * [#387] [DOC] Fix incorrect path for generators in the docs ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lato isn't particularly made for UI uses and I felt it was a little rough around
the edges; almost too friendly and unstructured for Administrate.
Instead, we can just use system fonts, especially now that Apple and Google have
both creating their own typefaces for UI use and are really strong typefaces.
Plus we get the benefit of not having to load web fonts!
Reference: https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/
It also means we have one less thing to rely on (Google Fonts)
Before (with Lato)
After (with system fonts, rendered as Apple’s San Francisco here)