Document renaming dashboard #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/customizing_dashboards.md
Outdated
| @@ -158,6 +158,17 @@ end | |||
|
|
|||
| [define your own]: /adding_custom_field_types | |||
|
|
|||
| To change dashboard name in sidebar menu, sub-header and search string simply use default ActiveRecord i18n translations for models: | |||
There was a problem hiding this comment.
I think we need some "the"s in the start here:
To change the Dashboard name in the sidebar
And would you mind removing "simply"? Whilst in this case it's true, I like to avoid words in our docs like "simply", "easily", etc as this is often not true for everyone.
Add docs of how to i18n dashboard name.
|
Sorry for broken English. Fixed. |
|
No worries, it always takes a bit to get the wording right. I'm going to merge this now, so thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#938
Add docs of how to i18n dashboard name.