Skip to content

Commit

Permalink
Avoid using the --without parameter to Bundler (#221)
Browse files Browse the repository at this point in the history
Much like `--path` (#220), we want to avoid using deprecated arguments.
We're only using these in our tests, too.

This change has the downside of removing the positive check -- it's
possible that `orange_juice`, `coffee`, `soda` could not be included in
the output whilst the feature itself fails.
  • Loading branch information
nickcharlton committed Feb 26, 2024
1 parent dba2b37 commit 2338a1e
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions spec/acceptance/bundle_without_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,10 @@
Appraisals

run "bundle install --local"
output = run "appraisal install --without drinks"
run "bundle config set --local without 'drinks'"
output = run "appraisal install"

expect(output).to include("Bundle complete")
expect(output).to(
match(/Gems in the group ['"]?drinks['"]? were not installed/),
)
expect(output).not_to include("orange_juice")
expect(output).not_to include("coffee")
expect(output).not_to include("soda")
Expand Down

0 comments on commit 2338a1e

Please sign in to comment.