Fix Travis build #134
Merged
Fix Travis build #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| include_examples :gemfile_dependencies_are_satisfied | ||
|
|
||
|
|
There was a problem hiding this comment.
Minor thing: could you remove this extra blank line?
There was a problem hiding this comment.
Sorry I missed that 😅
| map { |path| path.split('/').last }. | ||
| select { |gem| gem.include?(gem_name) } | ||
| map { |path| path.split('/').last }. | ||
| select { |gem| gem.include?(gem_name) } |
There was a problem hiding this comment.
We don't have Hound/automatic style linting on here, but I'd prefer the indentation stayed the same here.
|
Thanks! I noticed the build failed on Ruby 1.9.3. I wonder if here we should also pin the rake version (if that's possible in this scenario)? |
|
I thought the same to be honest although during the building of the branch never failed which is interesting. |
berkos
force-pushed
the
fix_travis_build
branch
from
9a239a3
to
4598aee
Compare
…ndle_with_custom_path_spec.rb`
berkos
force-pushed
the
fix_travis_build
branch
from
4598aee
to
31a97d4
Compare
|
Great! Thanks for following up with that. I'll merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
appraisal installproduces a different result locally vs Travis.locally:
vs
Travis:
Hypothesis is that newer versions of rvm in travis are installing the bundler as a default gem that cannot be uninstalled. relevant issue
Proposal is to check that
bundle installandbundle exec appraisal installproduces the same result rather than bundler is installed as a side effect.@nickcharlton please let me know if I do miss some context.
Thanks!