-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support nesting of Bundler block DSL #84
Conversation
|
||
def to_s | ||
[source_entry, | ||
ruby_version_entry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align the elements of an array literal if they span more than one line.
Do I have to convert all of existing single-quoted |
Thats fine. Please ignore Hound's comment on the quoting. I'll take a look at this this Friday. Thank you for your patch. |
I'm tagging this for 1.1.0. |
41e34c0
to
23884a8
Compare
Thanks, rebased to the master. |
23884a8
to
f96b591
Compare
Did further rebasing. 😃 |
@mshibuya Please don't worry about further rebasing. I'll pull down and fixing the conflict very soon. |
I've rebased the patch and made some fix to make sure that it works on Ruby 1.8.7 (as I added that a bit earlier) and merged that as 617e583. I really like how the code looks now. It's so much cleaner. Thank you so much for your patch! |
How wonderful, thank you for your hard work! |
This pull request enables nesting of Bundler block DSL(i.e.
group
,platforms
,git
,path
), which gives ability to express fairly complex dependency in Gemfile.Any suggestions will be greatly appreciated!