-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow commands with spaces to be constructed as new Commands #86
Conversation
If you were using the `appraisal` executable and passed an argument that contained spaces, those spaces would not be preserved when Appraisal went to execute the full command. For instance, this command... appraisal 4.2 rspec spec/some/file_spec.rb -e "some example group" *Should* be expanded as follows: BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e "some example group" ...but before this commit would be incorrectly expanded as follows: BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e some example group
run 'appraisal 1.0.0 ruby -rbundler/setup -rdummy "test with spaces.rb"' | ||
} | ||
|
||
expect(&assertion).not_to raise_error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add assertion for output as well? I think I care more that the command get executed and yield correct result than if we return zero exit status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, sure.
@sikachu Ready for re-review. |
@mcmire I squashed the commits and merged them. Thank you! |
If you were using the `appraisal` executable and passed an argument that contained spaces, those spaces would not be preserved when Appraisal went to execute the full command. For instance, this command... appraisal 4.2 rspec spec/some/file_spec.rb -e "some example group" *Should* be expanded as follows: BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e "some example group" ...but before this commit would be incorrectly expanded as follows: BUNDLE_GEMFILE=$PWD/gemfiles/4.2.gemfile rspec spec/some/file_spec.rb -e some example group Close #86
Sweet, thanks! |
If you were using the
appraisal
executable and passed an argument thatcontained spaces, those spaces would not be preserved when Appraisal
went to execute the full command. For instance, this command...
Should be expanded as follows:
...but before this commit would be incorrectly expanded as follows: