Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal OrderedHash and remove runtime activesupport dependency. #95

Closed
wants to merge 1 commit into from
Closed

Add minimal OrderedHash and remove runtime activesupport dependency. #95

wants to merge 1 commit into from

Conversation

omghax
Copy link
Contributor

@omghax omghax commented May 12, 2015

As discussed in #94, this PR adds a basic OrderedHash and makes activesupport a development dependency rather than a runtime one.

@nbibler
Copy link

nbibler commented May 12, 2015

It seems to be good to get away from activesupport features in production (thus the recreation of OrderedHash). For example, if an Appraisal configuration for a project uses a version of activesupport that is either missing OrderedHash or has a broken implementation of OrderedHash it would change the functionality of Appraisal. In that case, it would be non-obvious to diagnose and likely produce surprising side effects during execution.

Using OrderedHash here seems like it's a bit of overkill for the current usage, but this patch is certainly a short distance to removing the immediate need for a production dependency on activesupport. 👍

@sikachu
Copy link
Contributor

sikachu commented Jun 5, 2015

I merged this as 108d4c5.

@sikachu sikachu closed this Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants