Skip to content

Commit

Permalink
Add picture element, general cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
Tyson Gach committed Jul 24, 2014
1 parent 9f1f24e commit 6bdef8f
Show file tree
Hide file tree
Showing 8 changed files with 32 additions and 22 deletions.
24 changes: 12 additions & 12 deletions app/assets/stylesheets/_base.scss
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -4,21 +4,21 @@
* MIT License */ * MIT License */


// Variables // Variables
@import 'variables'; @import "variables";


// Neat Settings -- uncomment if using Neat -- must be imported before Neat // Neat Settings -- uncomment if using Neat -- must be imported before Neat
// @import 'grid-settings'; // @import "grid-settings";


// Extends // Extends
@import 'extends/button'; @import "extends/button";
@import 'extends/clearfix'; @import "extends/clearfix";
@import 'extends/errors'; @import "extends/errors";
@import 'extends/flashes'; @import "extends/flashes";
@import 'extends/hide-text'; @import "extends/hide-text";


// Typography and Elements // Typography and Elements
@import 'typography'; @import "typography";
@import 'forms'; @import "forms";
@import 'tables'; @import "tables";
@import 'lists'; @import "lists";
@import 'buttons'; @import "buttons";
3 changes: 2 additions & 1 deletion app/assets/stylesheets/_forms.scss
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ input[type="search"] {
@include appearance(none); @include appearance(none);
} }


input[type="checkbox"], input[type="radio"] { input[type="checkbox"],
input[type="radio"] {
display: inline; display: inline;
margin-right: $base-spacing / 4; margin-right: $base-spacing / 4;
} }
Expand Down
2 changes: 1 addition & 1 deletion app/assets/stylesheets/_grid-settings.scss
Original file line number Original file line Diff line number Diff line change
@@ -1,4 +1,4 @@
@import 'neat-helpers'; // or '../neat/neat-helpers' when not in Rails @import "neat-helpers"; // or "../neat/neat-helpers" when not in Rails


// Neat Overrides // Neat Overrides
// $column: 90px; // $column: 90px;
Expand Down
3 changes: 2 additions & 1 deletion app/assets/stylesheets/_lists.scss
Original file line number Original file line Diff line number Diff line change
@@ -1,4 +1,5 @@
ul, ol { ul,
ol {
margin: 0; margin: 0;
padding: 0; padding: 0;
list-style-type: none; list-style-type: none;
Expand Down
4 changes: 3 additions & 1 deletion app/assets/stylesheets/_tables.scss
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ td {
padding: ($base-spacing / 2) 0; padding: ($base-spacing / 2) 0;
} }


tr, td, th { tr,
td,
th {
vertical-align: middle; vertical-align: middle;
} }
12 changes: 9 additions & 3 deletions app/assets/stylesheets/_typography.scss
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -7,7 +7,12 @@ body {
line-height: $base-line-height; line-height: $base-line-height;
} }


h1, h2, h3, h4, h5, h6 { h1,
h2,
h3,
h4,
h5,
h6 {
font-family: $header-font-family; font-family: $header-font-family;
line-height: $header-line-height; line-height: $header-line-height;
margin: 0; margin: 0;
Expand Down Expand Up @@ -65,7 +70,8 @@ hr {
margin: $base-spacing 0; margin: $base-spacing 0;
} }


img { img,
picture {

This comment has been minimized.

Copy link
@alexgleason

alexgleason Aug 25, 2015

@tysongach What's the purpose of picture?

This comment has been minimized.

This comment has been minimized.

Copy link
@alexgleason

alexgleason Aug 26, 2015

Ahh cool, thank you for the link. I searched and didn't find it.

This comment has been minimized.

Copy link
@prisis

prisis Aug 26, 2015

You welcome :)

margin: 0; margin: 0;
max-width: 100%; max-width: 100%;
} }
Expand All @@ -82,6 +88,6 @@ cite {
font-style: italic; font-style: italic;


&:before { &:before {
content: '\2014 \00A0'; content: "\2014 \00A0";
} }
} }
2 changes: 1 addition & 1 deletion app/assets/stylesheets/extends/_button.scss
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
font-size: $base-font-size; font-size: $base-font-size;
font-weight: bold; font-weight: bold;
line-height: 1; line-height: 1;
padding: .75em 1em; padding: 0.75em 1em;
text-decoration: none; text-decoration: none;


&:hover { &:hover {
Expand Down
4 changes: 2 additions & 2 deletions spec/fixtures/application.scss
Original file line number Original file line Diff line number Diff line change
@@ -1,2 +1,2 @@
@import 'bourbon'; @import "bourbon";
@import 'base/base'; @import "base/base";

0 comments on commit 6bdef8f

Please sign in to comment.