Function strip-units - update warn message #1016
Conversation
Update warning message about strip-units function.
| @@ -14,8 +14,8 @@ | |||
|
|
|||
| @function strip-units($value) { | |||
| @if $output-bourbon-deprecation-warnings == true { | |||
| @warn "[Bourbon] [Deprecation] `strip-units` is deprecated and will be " + | |||
There was a problem hiding this comment.
This function is deprecated, so I think we should leave in [Deprecation] and is deprecated.
According to Wikipedia:
…deprecated status may also indicate the feature will be removed in the future.
As you mentioned in #1013, “Use the renamed strip-unit function instead” is a bit confusing because you can’t use that yet if you are still on 4.x. So we should re-word only that sentence to make it clear that you will need to use the renamed function when you upgrade to 5.0.
Change @warn message
| @@ -15,7 +15,7 @@ | |||
| @function strip-units($value) { | |||
| @if $output-bourbon-deprecation-warnings == true { | |||
| @warn "[Bourbon] [Deprecation] `strip-units` is deprecated and will be " + | |||
| "removed in 5.0.0. Use the renamed `strip-unit` function instead."; | |||
| "removed in version 5 and replaced by `strip-unit` function."; | |||
There was a problem hiding this comment.
Can we indent this line as it was before (to line up with @warn?
And swap version 5 for 5.0.0, so that we speak in specific version numbers?
Finally, I think we are missing the word the before strip-unit.
Update warn message about
strip-units()function to close #1013.