-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Division via / is deprecated and raises warnings #1107
Conversation
} @else { | ||
$v1: ($v1 / $ratio); | ||
$v1: math.div($v1, $ratio); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate dollar variable $v1 scss/no-duplicate-dollar-variables
$value: $v2; | ||
$v2: ($v2 / $ratio); | ||
$v2: math.div($v2, $ratio); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables
@@ -102,15 +104,15 @@ | |||
@if $increment < 0 { | |||
// adjust $v2 to just below $v1 | |||
@if $double-stranded { | |||
$v2: ($v2 / $ratio); | |||
$v2: math.div($v2, $ratio); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables
@@ -78,7 +80,7 @@ | |||
|
|||
// scale $v2 to just above $v1 | |||
@while $v2 > $v1 { | |||
$v2: ($v2 / $ratio); // will be off-by-1 | |||
$v2: math.div($v2, $ratio); // will be off-by-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables
It seems that hound is complaining about the structure of the code which I didn't change. I'm going to leave that alone since I don't 100% know how to fix it. Hopefully it can be accepted as is since it's unrelated. |
Checking in to see if this can be merged? |
Can someone please merge this so we stop getting the deprecation warnings. |
Sorry to notify you @tysongach as you appear to be the most activity on this repo in recent history. Could you help? |
I wish I could help, but I longer work at thoughtbot and am no longer involved in this project (I no longer have push access). |
@mike-burns looks like you've committed before & still work at thoughtbot, can you help sir or ask someone there who can? |
@joepagan hi! thanks for nudging us on this and @mike-burns thanks for bringing this to my attention. I'll review this and the hound warnings and get this merged for ya |
@vendelal thanks for the response, have you had an opportunity to review this yet? |
Hi @vendelal, did you had an opportunity to review this yet? Could you tag someone who can do it? @cpytel @tjvc @FerPerales |
@vendelal thanks for the approval/merge. Any chance of a release? |
Ran the SASS migration tool for division so the deprecation warnings stop being thrown. This should resolve #1106.