-
-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ran the SASS migration tool on division so deprecation warnings stop … #1110
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,8 @@ | |
/// | ||
/// @require {function} _fetch-bourbon-setting | ||
|
||
@use "sass:math"; | ||
|
||
@function modular-scale( | ||
$increment, | ||
$value: _fetch-bourbon-setting("modular-scale-base"), | ||
|
@@ -78,7 +80,7 @@ | |
|
||
// scale $v2 to just above $v1 | ||
@while $v2 > $v1 { | ||
$v2: ($v2 / $ratio); // will be off-by-1 | ||
$v2: math.div($v2, $ratio); // will be off-by-1 | ||
} | ||
@while $v2 < $v1 { | ||
$v2: ($v2 * $ratio); // will fix off-by-1 | ||
|
@@ -102,15 +104,15 @@ | |
@if $increment < 0 { | ||
// adjust $v2 to just below $v1 | ||
@if $double-stranded { | ||
$v2: ($v2 / $ratio); | ||
$v2: math.div($v2, $ratio); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables |
||
} | ||
|
||
@for $i from $increment through -1 { | ||
@if $double-stranded and ($v1 / $ratio) < $v2 { | ||
@if $double-stranded and math.div($v1, $ratio) < $v2 { | ||
$value: $v2; | ||
$v2: ($v2 / $ratio); | ||
$v2: math.div($v2, $ratio); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables |
||
} @else { | ||
$v1: ($v1 / $ratio); | ||
$v1: math.div($v1, $ratio); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unexpected duplicate dollar variable $v1 scss/no-duplicate-dollar-variables |
||
$value: $v1; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected duplicate dollar variable $v2 scss/no-duplicate-dollar-variables