Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes undefined method `exist?' for Dir:Class #54

Closed
wants to merge 1 commit into from

Conversation

nlisgo
Copy link

@nlisgo nlisgo commented Jan 31, 2012

I tried to run:

bourbon install

on my mac and the error was triggered on line 39.

I fixed it by replace Dir.exists? with File.directory?

@frank-who
Copy link

@nlisgo Are you using Ruby 1.8.7 by any chance?

@nlisgo
Copy link
Author

nlisgo commented Jan 31, 2012

Yes. Is it not supported? Everything runs fine for me after making that change to the file.

@frank-who
Copy link

Ah, that explains it. Dir does not have an exist? method in Ruby 1.8.7 it was only introduced in Ruby 1.9. If at all possible, I personally recommend upgrading your Ruby version, as Ruby 1.8.7 is slowly being phased out by developers in favour of Ruby 1.9.

@nlisgo
Copy link
Author

nlisgo commented Feb 1, 2012

I'm new to ruby and attempted the upgrade but I haven't been able to get bourbon to run with ruby1.9

I think it's because when I installed bourbon I used gem install but to download and use 1.9 I've had to use rvm. Did I mention I'm on a mac. 1.8.7 is the recommended release for lion. I would like to recommend that my peers (who are also mac users) use the bourbon library with sass. We are not ruby devs but Drupal so expecting my colleagues to get 1.9 setup is not feasible unfortunately. My fork of bourbon with this one line change which I assume works in 1.9 as well as 1.8.7 would remove a barrier for me and my colleagues.

Please let me know if you pull my amend.

@frank-who
Copy link

I am also on Mac and use rbenv as my ruby version manager of choice and currently running Ruby 1.9.3-p0 as my default. It's up to the maintainers of Bourbon if they want to make it backwards compatible with 1.8.7. And if they do, I am not sure how long they will keep that support as Rails will dump support for 1.8.7 in Rails 4 and that will set a trend.

It's entirely up to the Bourbon team what their plans are for backwards compatibility.

@plapier
Copy link

plapier commented Feb 17, 2012

@gabebw pushed the fix for this today:
45f6806. Let me know if you still run into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants