Fixes bug in the new font-face mixin #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| woff2: $font-url + "(\"#{$file-path}.woff2\")" format("woff2"), | ||
| woff: $font-url + "(\"#{$file-path}.woff\")" format("woff"), | ||
| ttf: $font-url + "(\"#{$file-path}.ttf\")" format("truetype"), | ||
| svg: $font-url + "(\"#{$file-path}.svg##{$font-family}\")" format("svg") |
There was a problem hiding this comment.
The interpolation seems simpler to me than escaping these quotes. Even if we are preferring double quotes.
There was a problem hiding this comment.
We were having a hard time stripping the quotes from the output later, which was the cause of the original bug.
|
This looks good other than the question of quotes. Excited to have WOFF2 in here 👍 |
|
Looking good. |
- Fix format of ttf files to truetype - Remove EOT src that didn’t have iefix query - Use double quotes - Fixes #594
tysongach
force-pushed
the
tg-font-face
branch
from
2834e85
to
4e15ab1
Compare
|
Yeah I just noticed this bug. |
|
@ollym @chrisnicola We’re looking into it. Thanks for the heads up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@whmii Would you mind taking a look at this?