-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Standardrb #1021
Open
minaslater
wants to merge
12
commits into
main
Choose a base branch
from
ms-standard
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Standardrb #1021
Commits on May 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 054bc18 - Browse repository at this point
Copy the full SHA 054bc18View commit details -
Configuration menu - View commit details
-
Copy full SHA for f52859a - Browse repository at this point
Copy the full SHA f52859aView commit details -
move next_migration_number to non-private
Standardrb flagged this class method being defined under private isn't actually private. We in fact doesn't want it to be private because it's being called by create_migration.
Configuration menu - View commit details
-
Copy full SHA for c66da0c - Browse repository at this point
Copy the full SHA c66da0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0786e11 - Browse repository at this point
Copy the full SHA 0786e11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c422d6d - Browse repository at this point
Copy the full SHA c422d6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e0ad969 - Browse repository at this point
Copy the full SHA e0ad969View commit details -
Configuration menu - View commit details
-
Copy full SHA for 614101a - Browse repository at this point
Copy the full SHA 614101aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 526db08 - Browse repository at this point
Copy the full SHA 526db08View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee12a9d - Browse repository at this point
Copy the full SHA ee12a9dView commit details
Commits on May 10, 2024
-
disable Style/ArgumentsForwarding check
Rubocop/Standard wants to use `&` instead of `&block` and that newer syntax rule breaks Ruby 3.0.4 tests
Configuration menu - View commit details
-
Copy full SHA for f683ab9 - Browse repository at this point
Copy the full SHA f683ab9View commit details
Commits on Jun 28, 2024
-
Fix specs and update Gemfile.lock
Standard accidentally took away **options in Authorization. This change replaces it and updates the Gemfile.lock while I'm here.
Configuration menu - View commit details
-
Copy full SHA for 7349a49 - Browse repository at this point
Copy the full SHA 7349a49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4204144 - Browse repository at this point
Copy the full SHA 4204144View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.