Deprecates avoid_sign_in #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyonj
force-pushed
the
jk-refactor-users-controller
branch
from
17aee87
to
b4e4292
Compare
| before { sign_out } | ||
| describe "on GET to #new" do | ||
| context "when signed out" do | ||
| context "with email" do |
There was a problem hiding this comment.
I'd get rid of this context and change the order of these two it blocks to say something like:
it "renders a form for a new user"
it "renders a form for a user with the query-string-provided email"
As a general rule don't use "should" in the it block description.
There was a problem hiding this comment.
Maybe a better description of the email one is:
it "defaults email to value provided in query string"
|
Few minor comments. Thanks for updating the spec as well. |
|
LGTM. Assuming travis passes, squash (2 commits looks good here) and merge. |
kenyonj
force-pushed
the
jk-refactor-users-controller
branch
from
f32ebf5
to
17fa2ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also refactors the
users_controller_specto follow theexpectsyntax.