Add raise: false to skip_before_filter #626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: In rails 5 if the filter has not been defined then an error will be raise This change addresses the need by: Adding raise: false to the passwords, sessions and users controller
| @@ -1,7 +1,7 @@ | |||
| class Clearance::SessionsController < Clearance::BaseController | |||
| before_filter :redirect_signed_in_users, only: [:new] | |||
| skip_before_filter :require_login, only: [:create, :new, :destroy] | |||
| skip_before_filter :authorize, only: [:create, :new, :destroy] | |||
| skip_before_filter :require_login, only: [:create, :new, :destroy], raise: false | |||
|
Merged in 23d93b8 - Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #621
In rails 5 if the filter has not been defined then
an error will be raised.
This change addresses the need by:
Adding raise: false to the passwords, sessions and
users controller