Test against Rails 5 master #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master includes a fix for rails/rails#23645, which is not yet included in a beta release. When updating to master, I also had to explicitly set the ActiveJob queue adapter to `inline` in tests, as it now defaults to `async`. With these changes, the non-acceptance test suite is now green and has no deprecations. Next up - the acceptance tests.
| @@ -13,7 +13,7 @@ gem "shoulda-matchers", "~> 2.8" | |||
| gem "sqlite3", "~> 1.3" | |||
| gem "timecop", "~> 0.6" | |||
| gem "pry", :require => false | |||
| gem "rails", "~> 5.0.0.beta1" | |||
| gem "rails", :git => "https://github.com/rails/rails" | |||
|
Never used appraisals - is the gemfile generated? |
|
Appraisal manages the gemfiles, yes. We need them checked in so we can get separate travis builds for each of them. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master includes a fix for rails/rails#23645,
which is not yet included in a beta release.
When updating to master, I also had to explicitly set the ActiveJob
queue adapter to
inlinein tests, as it now defaults toasync.With these changes, the non-acceptance test suite is now green and has
no deprecations. Next up - the acceptance tests.