Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Making [ActionMailer::Base] an optional dependancy #750

Closed
wants to merge 1 commit into from
Closed

Proposal: Making [ActionMailer::Base] an optional dependancy #750

wants to merge 1 commit into from

Conversation

clowder
Copy link

@clowder clowder commented Sep 5, 2017

We currently have no requirement for ActionMailer in our app, and like to run as lean a stack as possible – requiring components independently rather than using Rails.all.

Unfortunately though, because eager loading, using Clearance requires that we also include ActionMailer – even though we're sending all our mail through Mandrill.

I would like to propose that we soften the dependency on ActionMailer and also make the API for subbing out the mailer part of Clearance's config.

Happy to do the work to get this production ready, but want to float the idea before going too far down the rabbit hole.

Copy link
Contributor

@derekprior derekprior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hesitant to make this a configuration. I'm more inclined to be in favor of a guard clause in the default deliver_email method... something to the effect of return unless defined?(::ClearanceMailer)?

@derekprior derekprior closed this Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants