Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New location for fzf under macOS with ARM architecture #681

Closed
fievelk opened this issue Jan 1, 2021 · 1 comment · Fixed by #713
Closed

New location for fzf under macOS with ARM architecture #681

fievelk opened this issue Jan 1, 2021 · 1 comment · Fixed by #713

Comments

@fievelk
Copy link

fievelk commented Jan 1, 2021 •
edited

On macOS with M1 chip, Homebrew is now installed by default in /opt/homebrew/ (see Homebrew/install#373).

The current installation process determines whether fzf was installed via Homebrew, but only checks under /usr/local/:

dotfiles/vimrc.bundles

Lines 20 to 26 in 2a59c18

" If fzf has already been installed via Homebrew, use the existing fzf
" Otherwise, install fzf. The `--all` flag makes fzf accessible outside of vim
if isdirectory("/usr/local/opt/fzf")
Plug '/usr/local/opt/fzf'
else
Plug 'junegunn/fzf', { 'dir': '~/.fzf', 'do': './install --all' }
endif

I think adding a new check for /opt/homebrew/ might help for machines with M1 chips.
@marcelosalloum
Copy link

You can solve it by adding export FZF_BASE="/opt/homebrew/opt/fzf" to your bash file.

@danielnolan danielnolan mentioned this issue Mar 8, 2023
Merged
danielnolan added a commit that referenced this issue Mar 8, 2023
@danielnolan
Update the check for fzf installed via homebrew
4c0ebe0 
* The existing check for fzf installed via homebrew doesn't work form
  Apple silicon macs, nor does it work for those who use homebrew on
  Linux.
* Add brew_fzf_path variable to get the brew prefixed path
* Update the isdirectory conditional check this variable and use it for
  the Plug function call if it does
* Closes #681
danielnolan added a commit that referenced this issue Mar 9, 2023
@danielnolan
Update the check for fzf installed via homebrew (#713)
b21aa66 
* Update the check for fzf installed via homebrew

* The existing check for fzf installed via homebrew doesn't work form
  Apple silicon macs, nor does it work for those who use homebrew on
  Linux.
* Add brew_fzf_path variable to get the brew prefixed path
* Update the isdirectory conditional to check this variable and use it for
  the Plug function call if it is a directory.
* Closes #681
rtaibah added a commit that referenced this issue Jun 4, 2023
@rtaibah @danielnolan
Update the check for fzf installed via homebrew
e14f5a3 
* Update the check for fzf installed via homebrew

* The existing check for fzf installed via homebrew doesn't work form
  Apple silicon macs, nor does it work for those who use homebrew of Linux.
* Add brew_fzf_path variable to get the brew prefixed path
* Update the isdirectory conditional to check this variable and use it
  for the Plug function call if it is a directory.
* Closes #681

Co-authored-by: Daniel Nolan <danielnolan@thoughtbot.com>
adamjparrott pushed a commit to adamjparrott/dotfiles that referenced this issue Jul 2, 2023
@rtaibah @danielnolan
Update the check for fzf installed via homebrew
f762add 
* Update the check for fzf installed via homebrew

* The existing check for fzf installed via homebrew doesn't work form
  Apple silicon macs, nor does it work for those who use homebrew of Linux.
* Add brew_fzf_path variable to get the brew prefixed path
* Update the isdirectory conditional to check this variable and use it
  for the Plug function call if it is a directory.
* Closes thoughtbot#681

Co-authored-by: Daniel Nolan <danielnolan@thoughtbot.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the check for fzf installed via homebrew thoughtbot/dotfiles
2 participants
@marcelosalloum @fievelk