Introduce App#mountable? and App#to_rack
#386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
sd-mountable
branch
2 times, most recently
from
b847296
to
14d9b8a
Compare
For deploys that need to be mounted to be useful, [`File`][file] for example, this commit exposes an API for encapsulating that logic. `App#to_rack` will create an instance of a `Rack` application that can be mounted via `mount $RACK_APP => "/path"`. For deploys that don't serve assets from the file system, [`Redis`][redis] for example, `mountable?` should return `false`. [file]: https://github.com/thoughtbot/ember-cli-rails/blob/v0.7.0/lib/ember_cli/deploy/file.rb [redis]: https://github.com/seanpdoyle/ember-cli-rails-deploy-redis
seanpdoyle
force-pushed
the
sd-mountable
branch
from
14d9b8a
to
f510fe8
Compare
seanpdoyle
added a commit
to seanpdoyle/ember-cli-rails-assets
that referenced
this pull request
Jan 15, 2016
This functionality is provided by [`ember-cli-rails`][ember-cli-rails#386]. [ember-cli-rails#386]: thoughtbot/ember-cli-rails#386
seanpdoyle
added a commit
to seanpdoyle/ember-cli-rails-deploy-redis
that referenced
this pull request
Jan 15, 2016
`ember-cli-rails`'s deploy process [now determines if a deploy strategy needs to be mounted as a routable rack app][mountable]. This deployment strategy doesn't, but it still needs to quack like other strategies. [mountable]: thoughtbot/ember-cli-rails#386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For deploys that need to be mounted to be useful,
Fileforexample, this commit exposes an API for encapsulating that logic.
App#to_rackwill create an instance of aRackapplication that canbe mounted via
mount $RACK_APP => "/path".For deploys that don't serve assets from the file system,
Redisfor example,mountable?should returnfalse.