Fix dependencies check for compile command #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rescue DependencyError | ||
| false | ||
| end | ||
|
|
||
| def clean_ember_dependencies! | ||
| ember_dependency_directories.select(&:exist?).each(&:rmtree) | ||
| ember_dependency_directories.select(&:exist?).flat_map(&:children).each(&:rmtree) |
|
It does not seem like specs fail because of my change. @seanpdoyle is there anything else I could do in order to get this merged? |
|
@krasnoukhov unfortunately, it looks like I'll try to dedicate some time soon to get I'll keep you posted! |
|
@seanpdoyle I went ahead and added a PR for specs fixing: #456 |
This [commit] changed return value of `run` command to be `process.value` instead of `status`, so we need to use `success?` now. [commit]: ba83120
Remove contents only instead. This helps when either of `node_modules` or `bower_components` is a symlink.
|
@seanpdoyle This is green now. Can you cut a bugfix release once you merge it? Thanks |
|
Merged in https://github.com/thoughtbot/ember-cli-rails/releases/tag/v0.7.4. Released in Thanks! |
|
Thanks 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fixes actual bug, while the second one improves
clean_ember_dependencies!behavior when dependencies directory is a symlink.We use shared directories for
node_modulesandbower_componentsin order to speed up deploys. This change make cleanup work for that case.Thanks!