Don't return id field in params_for #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea of this, but I think we should delete the record's primary key instead of assuming it is :id. You can get this with the functions that Ecto defines for schemas MyModel.__schema__(:primary_key) |
|
Also we should document that the primary key is removed |
|
|
||
| defp ecto_fields(struct) do | ||
| [:__meta__] ++ struct.__schema__(:associations) ++ struct.__schema__(:primary_key) | ||
| end |
There was a problem hiding this comment.
I think this feels a bit roundabout because we already knowing it's dropping ecto fields because this function is called from drop_ecto_fields. So I think the abstraction is probably not necessary. What do you think about
record
|> Map.from_struct
|> Map.delete(:__meta__)
|> Map.delete(struct.schema__(:associations))
|> Map.delete(struct.schema__(:primary_key))However, I don't feel strongly so if you do, feel free to leave it as is
|
Two small comments and then LGTM :D |
I can't think of any use case where you would want the id field when using params_for. For something scenarios like submitting to an API, or getting the bare fields to test validations it would be rare to actually submit the id itself, and so the current behavior feels unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't think of any use case where you would want the id field when
using params_for. For something scenarios like submitting to an API, or
getting the bare fields to test validations it would be rare to
actually submit the id itself, and so the current behavior feels
unexpected.