-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Extract complicated runner code into private class
Factory#run was getting confusing - it added callbacks to the proxy, iterated over all attributes and operated on the proxy depending on if there were overridtes, mutated the overrides hash, and then operated on the mutated hash afterwards. This logic has been extracted into a private Factory::Runner class. The goal is to make it easier to understand everything that's occurring in order to instantiate and build the class.
- Loading branch information
1 parent
e1ece10
commit 105d972
Showing
1 changed file
with
78 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters