Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.1 and Rails 7 to CI #1526

Merged
merged 6 commits into from
Jan 14, 2022
Merged

Add Ruby 3.1 and Rails 7 to CI #1526

merged 6 commits into from
Jan 14, 2022

Conversation

petergoldstein
Copy link
Contributor

This PR adds the Ruby 3.1 and Rails 7 elements to the CI matrix. To support those changes a number of other changes were required:

  • Adding a basic Rails 7 Gemfile and updating Appraisals
  • Quoting 3.0 in the .github/workflows/build.yml file so that this entry pulls Ruby 3.0.x and not Ruby 3.1
  • Adding the "--disable-error_highlight" value for RUBYOPT in the build environment to disable Ruby 3.1 error highlighting
  • Bumping the version of standard to pick up a Ruby 3.1 compatible Rubocop version
  • Disabling the standard run for bundle exec rake for Rails version >= 3.1.0 because of a conflicting evaluation for Style/MethodMissingSuper for Ruby 3.1 and earlier Rubies

Copy link
Collaborator

@composerinteralia composerinteralia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It may be slightly easier to add Rails and Ruby separately, since there are quite a few changes here.

.github/workflows/build.yml Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
Appraisals Outdated Show resolved Hide resolved
spec/acceptance/build_stubbed_spec.rb Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@petergoldstein
Copy link
Contributor Author

@composerinteralia Ok, this is all green now. Let me know if you still want to split it into two different PRs.

@composerinteralia composerinteralia merged commit b7eb4db into thoughtbot:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants